Skip to content

test(nns): Clean up the testing for the initialization of neuron_minimum_dissolve_delay_to_vote_seconds #8804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonz-dfinity wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(nns): Clean up the testing for the initialization of neuron_minimum_dissolve_delay_to_vote_seconds #8804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions rs/nns/integration_tests/src/upgrade_canisters_with_golden_nns_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,13 @@ use ic_nns_governance_api::{
MonthlyNodeProviderRewards, NetworkEconomics, Vote, VotingPowerEconomics,
};
use ic_nns_test_utils::state_test_helpers::{
nns_get_most_recent_monthly_node_provider_rewards, nns_wait_for_proposal_execution,
scrape_metrics,
nns_get_most_recent_monthly_node_provider_rewards, scrape_metrics,
};
use ic_nns_test_utils::{
common::modify_wasm_bytes,
state_test_helpers::{
get_canister_status, manage_network_economics, nns_cast_vote,
nns_create_super_powerful_neuron, nns_propose_upgrade_nns_canister,
wait_for_canister_upgrade_to_succeed,
get_canister_status, nns_cast_vote, nns_create_super_powerful_neuron,
nns_propose_upgrade_nns_canister, wait_for_canister_upgrade_to_succeed,
},
};
use ic_nns_test_utils_golden_nns_state::new_state_machine_with_golden_nns_state_or_panic;
Expand Down Expand Up @@ -343,25 +341,6 @@ fn test_upgrade_canisters_with_golden_nns_state() {
repetition_number += 1;
};

// TODO[NNS1-3790]: Remove this once the mainnet NNS has initialized the
// TODO[NNS1-3790]: `neuron_minimum_dissolve_delay_to_vote_seconds` field.
let proposal_id = manage_network_economics(
&state_machine,
NetworkEconomics {
voting_power_economics: Some(VotingPowerEconomics {
neuron_minimum_dissolve_delay_to_vote_seconds: Some(
VotingPowerEconomics::DEFAULT_NEURON_MINIMUM_DISSOLVE_DELAY_TO_VOTE_SECONDS,
),
..Default::default()
}),
..Default::default()
},
neuron_controller,
neuron_id,
);
vote_yes_with_well_known_public_neurons(&state_machine, proposal_id.id);
nns_wait_for_proposal_execution(&state_machine, proposal_id.id);

let metrics_before = sanity_check::fetch_metrics(&state_machine);

perform_sequence_of_upgrades(&nns_canister_upgrade_sequence);
Expand Down
Loading