Skip to content

refactor: Move registry functionality out of the attestation crate#8779

Open
frankdavid wants to merge 6 commits intomasterfrom
frankdavid/move-blessed-guest-launch-measurements
Open

refactor: Move registry functionality out of the attestation crate#8779
frankdavid wants to merge 6 commits intomasterfrom
frankdavid/move-blessed-guest-launch-measurements

Conversation

@frankdavid
Copy link
Contributor

Number of transitive dependencies before -> after:

attestation: 175 -> 99
attestation_testing: 187 -> 101

@frankdavid frankdavid requested review from a team as code owners February 10, 2026 16:15
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@frankdavid
Copy link
Contributor Author

@dfinity/governance-team: There is a comment for updating unreleased_changelog.md, but I don't think my changes affect governance. Any recommendations?

let measurement3 = [11, 12, 13, 14, 15];
let measurement4 = [16, 17, 18, 19, 20]; // From unblessed version

let replica_versions_and_records = vec![
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is None a valid (and realistic) value for guest_launch_measurements? If so, could we also add it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants