feat!: http-auth-js library
#32
Conversation
Adds a crate that allows to run a local replica using a custom gateway. Prepares the work to customize the ic-gateway
peterpeterparker
left a comment
peterpeterparker
left a comment
There was a problem hiding this comment.
Not really a review, more rubber stamp with few comments that cross my mind on a quick read.
| * Calculates the ingress expiry timestamp in nanoseconds. | ||
| */ | ||
| function calculateIngressExpiry(expirationTimeMs: number): bigint { | ||
| const expiryTimestampMs = Date.now() + expirationTimeMs; |
There was a problem hiding this comment.
in @dfinity/utils there is a nowInBigIntNanoSeconds which can be handy here to remain in nanos
There was a problem hiding this comment.
It would be nice to keep this package free of dependencies as much as possible. The current @icp-sdk/core package is there just for speed, but ideally we could move here all the utility functions here
| } | ||
|
|
||
| // Set all authentication headers | ||
| req.headers.set(SIGNATURE_HEADER_NAME, signatureHeaderValue); |
There was a problem hiding this comment.
nitpick: found this imperative approach difficult to decrypt, skipped it
There was a problem hiding this comment.
What do you mean? Do you have a suggestion on how to improve it?
| } | ||
|
|
||
| function getSignatureHeaderValue(signatureName: SignatureName, signature: ArrayBuffer): string { | ||
| return `${signatureName}=:${base64Encode(signature)}:`; |
There was a problem hiding this comment.
No separator constant for =: unlike other separators?
There was a problem hiding this comment.
I wanted to keep the function as the source of truth in this case for better clarity
2 participants
Rework of the
http-auth-jslibrary to use the new HTTP protocol with BHTTP.Blocked by #31.