Skip to content

ci: bump macos runner to macos-15 #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwshang merged 2 commits into from
Jan 9, 2026
Merged

ci: bump macos runner to macos-15 #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babd163
ci: bump macos runner to macos-15
lwshang Jan 9, 2026
5efdbc9
try fix rust installation
lwshang Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04, macos-13-large]
os: [ubuntu-24.04, macos-15]
fail-fast: false
steps:
- name: Install Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be removed entirely. The runner image comes with rustup and then we don't need a 'sync with other file' instruction.

Copy link
Contributor Author

@lwshang lwshang Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most jobs use the stable toolchain (which is specified in rust-toolchain.toml). This msrv job explicitly overwrite to use the MSRV. So I believe we should keep it here, no?

uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.85.0 # MSRV, should sync with `rust-toolchain` in `Cargo.toml`
target: wasm32-unknown-unknown
targets: wasm32-unknown-unknown
- name: Checkout repository
uses: actions/checkout@v4
- name: Cache
Expand All @@ -52,11 +52,9 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04, macos-13-large]
os: [ubuntu-24.04, macos-15]
fail-fast: false
steps:
- name: Install Rust toolchain
run: rustup show active-toolchain || rustup toolchain install
- name: Checkout repository
uses: actions/checkout@v4
- name: Cache
Expand Down Expand Up @@ -93,13 +91,14 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-24.04, macos-13-large]
os: [ubuntu-24.04, macos-15]
fail-fast: false
steps:
- name: Install Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: nightly-2025-05-09 # 1.88.0
targets: wasm64-unknown-unknown
components: rust-src
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -133,8 +132,6 @@ jobs:
name: cargo fmt
runs-on: ubuntu-24.04
steps:
- name: Install Rust toolchain
run: rustup show active-toolchain || rustup toolchain install
- name: Checkout repository
uses: actions/checkout@v4
- name: Cache
Expand All @@ -158,8 +155,6 @@ jobs:
name: cargo clippy
runs-on: ubuntu-24.04
steps:
- name: Install Rust toolchain
run: rustup show active-toolchain || rustup toolchain install
- name: Checkout repository
uses: actions/checkout@v4
- name: Cache
Expand Down Expand Up @@ -193,8 +188,6 @@ jobs:
name: cargo doc
runs-on: ubuntu-24.04
steps:
- name: Install Rust toolchain
run: rustup show active-toolchain || rustup toolchain install
- name: Checkout repository
uses: actions/checkout@v4
- name: Cache
Expand Down
Loading