Skip to content

Conversation

@ClankPan
Copy link
Contributor

Summary

Add a replicated request extension so callers can set is_replicated via http::Request/Builder and have it propagated into IcHttpRequest.

Changes

  • Add IsReplicatedRequestExtension with set/get/builder helpers
  • Store is_replicated in http::Request/Builder extensions
  • Propagate is_replicated in HttpRequestConverter
  • Add/update conversion tests

@ClankPan ClankPan requested a review from a team as a code owner January 27, 2026 02:29
@github-actions
Copy link
Contributor

Thank you for contributing! Unfortunately this repository does not accept external contributions yet.

We are working on enabling this by aligning our internal processes and our CI setup to handle external contributions. However this will take some time to set up so in the meantime we unfortunately have to close this Pull Request.

We hope you understand and will come back once we accept external PRs.

— The DFINITY Foundation

Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @ClankPan! Overall LGTM, just some minor nits regarding documentation and some misformated imports (see the linter errors in the CI).

ClankPan and others added 4 commits January 28, 2026 11:31
Co-authored-by: Louis Pahlavi <louis.pahlavi@gmail.com>
Co-authored-by: Louis Pahlavi <louis.pahlavi@gmail.com>
Copy link
Contributor

@lpahlavi lpahlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @ClankPan!

@lpahlavi lpahlavi merged commit 34e79c7 into dfinity:main Jan 28, 2026
10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 30, 2026
lpahlavi added a commit that referenced this pull request Feb 2, 2026
## 🤖 New release

* `canhttp`: 0.4.0 -> 0.5.0 (✓ API compatible changes)
* `ic-canister-runtime`: 0.1.1 -> 0.1.2 (✓ API compatible changes)
* `ic-pocket-canister-runtime`: 0.2.0 -> 0.3.0 (⚠ API breaking changes)
* `ic-agent-canister-runtime`: 0.1.1 -> 0.1.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `canhttp`

<blockquote>

## [0.5.0] - 2026-01-30

### Added

- Add support for batched JSON-RPC requests
([#65](#65))
- Add replicated request extension
([#70](#70))

### Changed

- Update dependencies
([#72](#72))

[0.5.0]:
https://github.com/dfinity/canhttp/compare/canhttp-0.4.0..canhttp-0.5.0
</blockquote>

## `ic-canister-runtime`

<blockquote>

## [0.1.2] - 2026-01-30

### Changed

- Update dependencies
([#72](#72))

[0.1.2]:
https://github.com/dfinity/canhttp/compare/ic-canister-runtime-v0.1.1..ic-canister-runtime-v0.1.2
</blockquote>

## `ic-pocket-canister-runtime`

<blockquote>

## [0.3.0] - 2026-01-30

### Changed

- **Breaking:** Bump `pocket-ic` to v12.0.0
([#72](#72))

[0.3.0]:
https://github.com/dfinity/canhttp/compare/ic-pocket-canister-runtime-v0.2.0..ic-pocket-canister-runtime-v0.3.0
</blockquote>

## `ic-agent-canister-runtime`

<blockquote>

## [0.1.2] - 2026-01-30

### Changed

- Update dependencies
([#72](#72))

[0.1.2]:
https://github.com/dfinity/canhttp/compare/ic-agent-canister-runtime-v0.1.1..ic-agent-canister-runtime-v0.1.2
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants