fix/icrc2_approve-method

[h1teshtr1path1]

I can see assertion in 2nd last line in icrc2_approve method will always throw err, am I missing something?

[roman-kashitsyn]

The assertion states that the approver balance goes down by effectiveFee once the ledger records the Approve transaction. Do you observe this assertion failing?

[h1teshtr1path1]

Ahhh I see. In that case, in Motoko implementation, balance function doesn't handle #Approve case.

func balance(account : Account, log : TxLog) : Nat { var sum = 0; for (tx in log.vals()) { switch (tx.operation) { case (#Burn(args)) { if (accountsEqual(args.from, account)) { sum -= args.amount }; }; case (#Mint(args)) { if (accountsEqual(args.to, account)) { sum += args.amount }; }; case (#Transfer(args)) { if (accountsEqual(args.from, account)) { sum -= args.amount + tx.fee; }; if (accountsEqual(args.to, account)) { sum += args.amount }; }; case (#Approve(_)) {}; }; }; sum; };

I think this is the reason assertion throwing error in all cases.