Open
Conversation
The NMSAR ICS 204 form does not have all of its team member fields labeled
in a rational order. The team leader's name field is called "Text1" and
subsequent team member names are in fields called Name{n} where n ranges
from 2 through 8. The resource name and skill fields are all identically
named with only the suffix 1-8 changing --- the 1 pertains to the team
leader.
As written originally, the code tried to stuff team members 2-8 into
fields 1-7, and the result was team members missing from the assignment
form.
This commit fixes the error, making sure that the team leader is put into
Text 1 (which was correct before) and not then overwritten by the next
team member (or made blank).
This was tested with real mission data, after observing that the form was
wrong with the original code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NMSAR ICS 204 form does not have all of its team member fields labeled
in a rational order. The team leader's name field is called "Text1" and
subsequent team member names are in fields called Name{n} where n ranges
from 2 through 8. The resource name and skill fields are all identically
named with only the suffix 1-8 changing --- the 1 pertains to the team
leader.
As written originally, the code tried to stuff team members 2-8 into
fields 1-7, and the result was team members missing from the assignment
form.
This commit fixes the error, making sure that the team leader is put into
Text 1 (which was correct before) and not then overwritten by the next
team member (or made blank). It also gets all the other members populated into the Name2-Name8 fields correctly.
This was tested with real mission data, after observing that the form was
wrong with the original code.