Skip to content

Conversation

@rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Jul 31, 2025

Brief overview of changes

Having a quick stab at the service navigation. Ultimately required by shinyGovstyle, but creating in dfeshiny in case we want to demo / test it out here first.

Why are these changes being made?

To provide a fuller suite of GDS components.

Detailed description of changes

...

Additional information for reviewers

Of interest for @pauljamesdfe & @cjrace

Still needs testing it actually works and some better fleshed out examples. I've basically just copied how we handle the footer links and gone with that. May be better ways to do it, but this seemed a nice simple starter for 10.

Issue ticket number/s and link

...

@rmbielby rmbielby self-assigned this Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.33%. Comparing base (e402994) to head (a4bbed0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   66.30%   63.33%   -2.98%     
==========================================
  Files          14       15       +1     
  Lines        1279     1339      +60     
==========================================
  Hits          848      848              
- Misses        431      491      +60     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2ba67...a4bbed0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cjrace
Copy link
Contributor

cjrace commented Aug 14, 2025

I have made an exceptionally crude start already on shinyGovstyle on branch a little while back (GitHub Copilot helped mock out an initial structure), related issue - dfe-analytical-services/shinyGovstyle#99.

I think there's enough wider demand, and enough space to experiment in shinyGovstyle (e.g. could even flag the individual function as experimental) that we should move this work to there and go direct into shinyGovstyle rather than doing a DfE version first and needing to worry about porting over later, especially as we're admins / maintainers on there too now.

Very happy for you to take this code and put onto my branch or just start a new one on shinyGovstyle copying from what you've done here if what's on mine isn't helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants