Skip to content

Conversation

@rmbielby
Copy link
Contributor

Brief overview of changes

Adding reusable and example script for triggering an Air workflow.

Why are these changes being made?

To help analysts style their dashboard code quickly

Detailed description of changes

...

Additional information for reviewers

...

Issue ticket number/s and link

...

@rmbielby rmbielby force-pushed the workflows/air-reusable branch 3 times, most recently from 7d43de4 to a9efac8 Compare June 23, 2025 13:26
@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (e402994) to head (0ac9e41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files          14       14           
  Lines        1279     1279           
=======================================
  Hits          848      848           
  Misses        431      431           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2ba67...0ac9e41. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmbielby rmbielby force-pushed the workflows/air-reusable branch from a9efac8 to bec2cc8 Compare June 23, 2025 13:44
@cjrace
Copy link
Contributor

cjrace commented Jul 4, 2025

Think you're still working on it, though a quick comment while I'm here, is there any reason why we're triple naming the workflow? Could we just do it as air / air, or even just air?
image

@cjrace
Copy link
Contributor

cjrace commented Jul 10, 2025

For this it's worth considering:

  • how much we may or may not want people to also be using the usethis::use_air() function to set it all up
  • if the positron / vscode default settings are worth pushing for project-level settings (I set them up in shinyGovstyle here (only look at the first 2 commits before all the formatting changes) - 124 tidy up inbetween milestones shinyGovstyle#161)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants