Skip to content

Conversation

@cjrace
Copy link
Contributor

@cjrace cjrace commented Jan 23, 2026

Brief overview of changes

Quick one as I figured this out elsewhere, and thought it might be handy to stash somewhere. The dfeR contributing file has become the main one for package maintainers for us to put stuff like this on.

Why are these changes being made?

Had a weird issue on another package with test failures I couldn't recreate, until I then updated my local versions of the packages that package depended on. Also needed it for automating the install of dependencies in a Dockerfile. Figured this was a helpful shortcut to stash for future me, and for others.

Essential Checklist

  • I have read the contributing guidelines
  • The code follows the package style and naming conventions
  • All new and existing tests pass (devtools::test())
  • I have updated the documentation using devtools::document()
  • I have checked that my changes do not break existing functionality

Consider (as applicable)

  • I have added or updated documentation (function documentation, vignettes, readme, etc.)
  • I have updated the NEWS.md file with a summary of my changes
  • I have considered if a version bump is required in DESCRIPTION
  • I have added examples or usage where relevant
  • I have resolved styling (formatted using Air, or styler::style_pkg()) and lintr issues (lintr::lint_package())

@cjrace cjrace requested a review from mzayeddfe January 23, 2026 02:26
@cjrace cjrace added the documentation Missing or incomplete documentation label Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.19%. Comparing base (378f30e) to head (db97f0a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   57.19%   57.19%           
=======================================
  Files          18       18           
  Lines        1509     1509           
=======================================
  Hits          863      863           
  Misses        646      646           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378f30e...db97f0a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mzayeddfe
Copy link
Contributor

Thanks for this @cjrace ! Super helpful to have in there. I just tested the code and I keep getting this error:

image

I tried to see if there any fixes like PATH not being configured properly on my machine or package cache interference but nothing worked. I was wondering if you run the code now, do you get something similar?

@cjrace cjrace force-pushed the docs/tip-updating-local-pkgs branch from bc5ff44 to db97f0a Compare January 27, 2026 15:36
@cjrace
Copy link
Contributor Author

cjrace commented Jan 27, 2026

Thanks for this @cjrace ! Super helpful to have in there. I just tested the code and I keep getting this error:

image I tried to see if there any fixes like PATH not being configured properly on my machine or package cache interference but nothing worked. I was wondering if you run the code now, do you get something similar?

Interesting - on both personal and work laptops it works okay for me? E.g.

image

Even if all dependencies are up to date it just shows this instead
image

@Lsnaathorst1
Copy link
Contributor

Lsnaathorst1 commented Feb 10, 2026

@cjrace @mzayeddfe, tested at Menna's request and the code works for me:
image

image

Copy link
Contributor

@mzayeddfe mzayeddfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @Lsnaathorst1 and @cjrace confirming the code works for both of them, I'm happy to approve this PR and I can investigate why it's not working for me later as to not block this PR.

@cjrace cjrace merged commit 375de08 into main Feb 12, 2026
12 checks passed
@cjrace cjrace deleted the docs/tip-updating-local-pkgs branch February 12, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Missing or incomplete documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants