feat: update GitHub ARC Runners configuration and remove unused resources

[avnes]

Describe your changes

This pull request refactors the Github ARC Runners Terraform module to simplify configuration, reduce duplication, and improve maintainability. It removes several variables and resource files, consolidates configuration logic, and standardizes naming conventions. The changes also introduce new variable handling for runner memory resources and update how dependencies and substitutions are managed in the FluxCD manifests.

Key changes:

Simplification and Consolidation

• Removed redundant variables such as deploy_name, namespace, and multiple runner configuration settings from vars.tf and replaced them with local variables and a single runner_resource_memory variable. This reduces complexity and potential for misconfiguration. [1] [2]
• Deleted the creation of several individual YAML files (patch.yaml, serviceaccount.yaml, role.yaml, rolebinding.yaml) and their associated Terraform resources, consolidating configuration into the main helm_install YAML. [1] [2]

Improved Naming and Variable Handling

• Standardized naming by using local.deploy_name throughout instead of a variable, and hardcoded the namespace to arc-runners in the relevant FluxCD manifests. [1] [2]
• Updated module and variable references in parent modules and test configurations to align with the new, simplified variable set. [1] [2] [3]

FluxCD and AWS Integration

• Added aws_caller_identity data source and included its ID as a substitution in the FluxCD manifest, enabling dynamic AWS account integration for the runners. [1] [2]
• Updated dependencies and dependsOn references in the FluxCD manifests to use standardized names, ensuring correct deployment order.

Dependency Management

• Added the AWS provider to versions.tf to support the new AWS data source usage.

These changes streamline the deployment and management of Github ARC Runners, making the module easier to use and maintain.

Checklist before requesting a review

• I have tested changes in my sandbox
• I have added the needed changes in the test/integration folder to apply my changes in QA. Read the guide on adding environment variables in QA
• I have rebased the code to master (or merged in the latest from master)

Is it a new release?

• Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code