Fix responsive behaviour to avoid to break mobile compatibility #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Can you please review and merge this patch? This issue is really annoying and occurs on every website using the plugin 🙏 |
Contributor
|
@audrasjb but was is this doing in your opinion? |
Contributor
should solve both issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI,
Related: #42
This fix is tested on all our websites and works fine.
I prefer that fix to be merged in cookie-notice codebase because actually we are overriding your stylesheet to handle the issue, and this is not super clean :)
Thanks,
Jb, CTO of Whodunit webagency