Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Biome (linter + formatter) and ESLint with oxlint and oxfmt from the oxc project. Biome served well but oxlint and oxfmt are faster, have better rule coverage for correctness/suspicious categories, and provide native Tailwind class sorting without plugins. This also consolidates the docs/ linting setup — instead of separate
biome.json+eslint.config.mjsin docs/, a single root.oxlintrc.jsonwithoverrideshandles both the main package and docs.Changes
Tooling config
.oxlintrc.json— Add root config: correctness rules as errors, suspicious as warnings, with overrides for docs/ to enable react, jsx-a11y, and nextjs plugin rules..oxfmtrc.json— Add formatter config: 120 line width, no semicolons, single quotes, import sorting, Tailwind class sorting scoped to docs/.biome.json,docs/biome.json,docs/eslint.config.mjs— Delete. Fully replaced by the oxc configs above.Dependency changes
package.json— Remove@biomejs/biome, addoxlint+oxfmt. Updatelint,lint:fix, andformatscripts.docs/package.json— Removeeslint,eslint-config-next,eslint-plugin-tailwindcss. Updatelintscript to use oxlint with docs override.Lint fixes (non-mechanical)
src/platforms/discord/client.ts— Remove unusedlastErrorvariable that was declared but never assigned. Simplify post-retry error throw.src/shared/utils/concurrency.ts— Replacenew Array(n)withArray.from({ length: n })to satisfy theno-new-arraycorrectness rule.src/platforms/teams/index.ts— Delete empty barrel file flagged as dead code.Formatting (mechanical)
oxfmt applied across all source, test, doc, and skill files. Changes are whitespace/style only — no logic modifications. Roughly 180 files touched, mostly trailing newlines and quote normalization.
Testing
Summary by cubic
Replace Biome and ESLint with
oxlintandoxfmtfor faster linting/formatting, better rule coverage, and native Tailwind class sorting in docs. Unifies tooling with single root configs and updates scripts without changing runtime behavior.Dependencies
oxlintandoxfmt.@biomejs/biome, and indocs/removeeslint,eslint-config-next,eslint-plugin-tailwindcss.lint/lint:fix/formatnow useoxlint/oxfmt(root anddocs/).Refactors
.oxlintrc.json(root ignores) and.oxfmtrc.json(120 width, single quotes, no semicolons, import sorting, Tailwind class sorting scoped todocs/).biome.json,docs/biome.json,docs/eslint.config.mjs.oxfmtacross the repo (style-only). Minor lint fixes, e.g. simplify retry error insrc/platforms/discord/client.ts.Written for commit 4ff131a. Summary will update on new commits.