Skip to content

fix: carrers page issues and enhance filters #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junaiddshaukat merged 1 commit into from
Jan 1, 2026
Merged

fix: carrers page issues and enhance filters #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/admin/dashboard/jobs/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ export default function JobsAdminPage() {
if (!formData.title.trim()) return 'Title is required';
if (!formData.company.trim()) return 'Company is required';
if (!formData.description.trim()) return 'Description is required';
if (!formData.applyUrl.trim() && !formData.applyEmail.trim()) return 'Provide apply URL or apply email';
return '';
};

Expand Down Expand Up @@ -242,7 +241,7 @@ export default function JobsAdminPage() {
<DialogContent className="max-w-2xl w-[calc(100vw-1.5rem)] sm:w-full max-h-[90vh] overflow-hidden p-4 sm:p-6 grid-rows-[auto,1fr]">
<DialogHeader>
<DialogTitle>{editingId ? 'Edit Job' : 'Create Job'}</DialogTitle>
<DialogDescription>Fill in the job details. At least one apply method is required.</DialogDescription>
<DialogDescription>Fill in the job details. Apply URL/Email are optional.</DialogDescription>
</DialogHeader>

<form onSubmit={handleSubmit} className="flex flex-col min-h-0">
Expand Down
116 changes: 111 additions & 5 deletions app/carrers/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@ export default function CarrersPage() {
const [loading, setLoading] = useState(true);
const [search, setSearch] = useState('');
const [audience, setAudience] = useState<'all' | 'Students' | 'Professionals' | 'Both'>('all');
const [workplace, setWorkplace] = useState<'all' | 'Remote' | 'Hybrid' | 'Onsite'>('all');
const [employment, setEmployment] = useState<'all' | 'Internship' | 'Full-time' | 'Part-time' | 'Contract'>('all');
const [applyOpen, setApplyOpen] = useState(false);
const [selectedJob, setSelectedJob] = useState<JobDoc | null>(null);
const [detailsOpen, setDetailsOpen] = useState(false);
const [detailsJob, setDetailsJob] = useState<JobDoc | null>(null);

useEffect(() => {
fetch('/api/jobs')
Expand All @@ -51,6 +55,8 @@ export default function CarrersPage() {
const q = search.trim().toLowerCase();
return jobs.filter((j) => {
if (audience !== 'all' && (j.audience || 'Both') !== audience) return false;
if (workplace !== 'all' && (j.workplaceType || 'Remote') !== workplace) return false;
if (employment !== 'all' && (j.employmentType || 'Full-time') !== employment) return false;
if (!q) return true;
return (
j.title?.toLowerCase().includes(q) ||
Expand All @@ -59,13 +65,18 @@ export default function CarrersPage() {
(j.tags || []).join(' ').toLowerCase().includes(q)
);
});
}, [jobs, search, audience]);
}, [jobs, search, audience, workplace, employment]);

const openApply = (job: JobDoc) => {
setSelectedJob(job);
setApplyOpen(true);
};

const openDetails = (job: JobDoc) => {
setDetailsJob(job);
setDetailsOpen(true);
};

const copyToClipboard = async (text: string) => {
try {
await navigator.clipboard.writeText(text);
Expand All @@ -79,7 +90,7 @@ export default function CarrersPage() {
<div className="max-w-3xl">
<h1 className="text-3xl sm:text-4xl font-bold">Careers</h1>
<p className="text-muted-foreground mt-3">
Hand-picked opportunities for students and professionals from our community.
Hand-picked opportunities for students and professionals across Dev Weekends and Dev Weekends partner companies.
</p>
</div>

Expand All @@ -101,6 +112,29 @@ export default function CarrersPage() {
<SelectItem value="Both">Both</SelectItem>
</SelectContent>
</Select>
<Select value={workplace} onValueChange={(v) => setWorkplace(v as any)}>
<SelectTrigger className="w-[180px]">
<SelectValue placeholder="Workplace" />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All Workplaces</SelectItem>
<SelectItem value="Remote">Remote</SelectItem>
<SelectItem value="Hybrid">Hybrid</SelectItem>
<SelectItem value="Onsite">Onsite</SelectItem>
</SelectContent>
</Select>
<Select value={employment} onValueChange={(v) => setEmployment(v as any)}>
<SelectTrigger className="w-[180px]">
<SelectValue placeholder="Employment" />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All Employment</SelectItem>
<SelectItem value="Internship">Internship</SelectItem>
<SelectItem value="Full-time">Full-time</SelectItem>
<SelectItem value="Part-time">Part-time</SelectItem>
<SelectItem value="Contract">Contract</SelectItem>
</SelectContent>
</Select>
<div className="flex-1" />
<Button asChild variant="outline">
<Link href="https://linktr.ee/DevWeekends" target="_blank" rel="noopener noreferrer">
Expand Down Expand Up @@ -159,9 +193,14 @@ export default function CarrersPage() {
) : null}
</CardContent>
<CardFooter className="pt-0">
<Button className="w-full" onClick={() => openApply(job)}>
Apply
</Button>
<div className="w-full flex flex-col sm:flex-row gap-2">
<Button className="w-full" variant="outline" onClick={() => openDetails(job)}>
Read more
</Button>
<Button className="w-full" onClick={() => openApply(job)}>
Apply
</Button>
</div>
</CardFooter>
</Card>
);
Expand All @@ -170,6 +209,73 @@ export default function CarrersPage() {
)}
</div>

<Dialog
open={detailsOpen}
onOpenChange={(open) => {
setDetailsOpen(open);
if (!open) setDetailsJob(null);
}}
>
<DialogContent className="w-[calc(100vw-1.5rem)] sm:w-full max-w-2xl max-h-[90vh] overflow-hidden p-4 sm:p-6 grid-rows-[auto,1fr]">
<DialogHeader>
<DialogTitle>Job Details</DialogTitle>
<DialogDescription>
{detailsJob ? (
<>
{detailsJob.title} @ {detailsJob.company}
</>
) : (
'Job details'
)}
</DialogDescription>
</DialogHeader>

<div className="min-h-0 overflow-y-auto pr-1 space-y-4">
<div className="text-sm text-muted-foreground space-y-1">
<div>
<span className="text-foreground font-semibold">Company:</span>{' '}
<span className="text-foreground">{detailsJob?.company || ''}</span>
</div>
<div>
<span className="text-foreground font-semibold">Location:</span>{' '}
<span>{detailsJob?.location || 'Not specified'}</span>
</div>
<div>
<span className="text-foreground font-semibold">Deadline:</span>{' '}
<span>
{detailsJob?.deadline ? new Date(detailsJob.deadline).toLocaleDateString() : 'Not specified'}
</span>
</div>
</div>

<div className="space-y-2">
<div className="text-sm font-semibold">Description</div>
<div className="text-sm whitespace-pre-wrap">{detailsJob?.description || ''}</div>
</div>

<div className="space-y-2">
<div className="text-sm font-semibold">Requirements</div>
<div className="text-sm whitespace-pre-wrap">
{detailsJob?.requirements?.trim() ? detailsJob.requirements : 'Not provided'}
</div>
</div>

{Array.isArray(detailsJob?.tags) && detailsJob!.tags!.length > 0 ? (
<div className="space-y-2">
<div className="text-sm font-semibold">Tags</div>
<div className="flex flex-wrap gap-1">
{detailsJob!.tags!.map((t, idx) => (
<Badge key={`details-${detailsJob!._id}-${idx}`} variant="outline">
{t}
</Badge>
))}
</div>
</div>
) : null}
</div>
</DialogContent>
</Dialog>

<Dialog
open={applyOpen}
onOpenChange={(open) => {
Expand Down
13 changes: 0 additions & 13 deletions models/Job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,6 @@ const jobSchema = new Schema(
{ timestamps: true }
);

// Basic safety: don't allow jobs without any apply method
jobSchema.pre('validate', function (next: (err?: any) => void) {
// @ts-expect-error - mongoose doc typing
const applyUrl = (this.applyUrl || '').toString().trim();
// @ts-expect-error - mongoose doc typing
const applyEmail = (this.applyEmail || '').toString().trim();
if (!applyUrl && !applyEmail) {
// @ts-expect-error - mongoose doc typing
this.invalidate('applyUrl', 'Either applyUrl or applyEmail is required');
}
next();
});

export const Job = models.Job || mongoose.model('Job', jobSchema);