[Beta] solution to altered passwords during installation#138
Open
paa93 wants to merge 2 commits intodevryan:masterfrom
404rq:master
Open
[Beta] solution to altered passwords during installation#138paa93 wants to merge 2 commits intodevryan:masterfrom 404rq:master
paa93 wants to merge 2 commits intodevryan:masterfrom
404rq:master
Conversation
added 2 commits
January 26, 2016 11:14
Allows special symbols like '%' to be passed and not modified without notification
Accepts special symbols like '%' to be passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords containing symbols like '%' where altered without notifying the user resulting in error messages saying the password is wrong while trying to connect to a MySQL database despite knowing its' right. My guess is that the ajax function automatically encodes/decodes the data in it's post request making a password like: 'abc%123' become: 'abc3' while the php function didn't perform any attempt to restore the original password.
(This is not tested) but it shows the concept and the cause of this issue.