Skip to content

Conversation

@grapefruit13
Copy link
Contributor

@grapefruit13 grapefruit13 commented Jan 25, 2025

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  1. Typography - Body3Black 중복 선언으로 인한 에러 해결
  2. ProfileImage 구현
  3. NavProfile, MyPage에 ProfileImage 적용

설명 (선택)

  • origin dev 풀받고 보니까 Typography에서 오류가 나더라고요. 머지할 때는 컨플릭 없었는데 런타임에서 컴포넌트 중복선언했다고 오류 나서 두번째로 Body3Black 선언한거 삭제했습니다
  • ProfileImage 컴포넌트 적용한건 아래 사진 보시면 됩니다~ 마이페이지에서 Image 태그 그대로 썼던 부분은 주석처리해두었어요

스크린샷

1. nav

image

2. mypage

image

리뷰 요구사항

@grapefruit13 grapefruit13 self-assigned this Jan 25, 2025
@grapefruit13 grapefruit13 marked this pull request as ready for review January 25, 2025 14:36
@grapefruit13 grapefruit13 requested a review from plla2 January 25, 2025 14:37
Copy link
Member

@plla2 plla2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@grapefruit13 grapefruit13 merged commit af77f15 into dev Jan 26, 2025
1 check passed
@grapefruit13 grapefruit13 deleted the THKV-128 branch January 26, 2025 02:16
plla2 added a commit to plla2/NNplanner-FE that referenced this pull request Jan 26, 2025
Feat[THKV-128] : Typography 충돌 해결, ProfileImage 구현
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants