Feat[#THKV-119] : NavProfile 리디자인 적용 및 Header 구현 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plla2
approved these changes
Jan 13, 2025
Comment on lines
9
to
14
| const [isMounted, setIsMounted] = useState(false); | ||
| const username = useUserStore((state) => state.username); | ||
|
|
||
| useEffect(() => { | ||
| setIsMounted(true); | ||
| }, []); |
Member
There was a problem hiding this comment.
저희 isMounted 처럼 clientonly에서 사용할 훅 커스텀훅으로 빼도 좋을 것 같습니다!
chart 같은 브라우저 전용에서나 window객체를 사용할 때같이 필요할 때가 있을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
네 분리해서 커밋 남기겠습니다~
Comment on lines
+46
to
+50
| export const Subtitle2Black = customTypography('span', { | ||
| type: 'Subtitle2', | ||
| color: 'black', | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
오늘 작업하면서 이부분처럼 customTypography 선언한 부분 변경해두겠습니다
grapefruit13
force-pushed
the
THKV-119
branch
from
ed32ddb to
14c02fc
Compare
plla2
added a commit
to plla2/NNplanner-FE
that referenced
this pull request
Jan 13, 2025
Feat[#THKV-119] : NavProfile 리디자인 적용 및 Header 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
유형
작업 내용
설명
스크린샷
리뷰 요구사항