Feat[#THKV-118] : Navbar 리디자인 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plla2
approved these changes
Jan 13, 2025
Member
plla2
left a comment
plla2
left a comment
There was a problem hiding this comment.
제가 customTypography 네이밍에 대한 메세지를 너무 늦게봐서.. 제가 오늘 작업할 때 네이밍이랑 사용된 곳 한번에 수정해둘까요? 아니면 각자 선언한 부분 각자 작업 하는게 편하실까요?
| width={ICON_SIZE} | ||
| height={ICON_SIZE} | ||
| /> | ||
| <span>{name}</span> |
Member
There was a problem hiding this comment.
해당 Typography도 hover 디자인 추가되면 추가하실 예정이신가요??
Contributor
Author
There was a problem hiding this comment.
엇 typo 넣는걸로 바꿀게여 놓쳤네요
Contributor
Author
There was a problem hiding this comment.
제가 customTypography 네이밍에 대한 메세지를 너무 늦게봐서.. 제가 오늘 작업할 때 네이밍이랑 사용된 곳 한번에 수정해둘까요? 아니면 각자 선언한 부분 각자 작업 하는게 편하실까요?
한 번에 수정해주시면 좋을 것 같습니다! 아직까지는 custom typo 쓴 곳이 많지 않아서여
plla2
reviewed
Jan 13, 2025
| true: 'bg-green-100 text-green-800 ', | ||
| false: 'text-gray-600', | ||
| true: 'bg-grey-900 text-green-500', | ||
| false: 'text-gray-500', |
plla2
added a commit
to plla2/NNplanner-FE
that referenced
this pull request
Jan 13, 2025
Feat[#THKV-118] : Navbar 리디자인
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
유형
작업 내용
설명 (선택)
스크린샷
리뷰 요구사항