Skip to content

Conversation

@plla2
Copy link
Member

@plla2 plla2 commented Jan 11, 2025

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • Typography color variants 네이밍 수정

리뷰 요구사항

  • color variants 네이밍을 grey의 컬러들이 다양하게 쓰여서 grey100, grey200 이런식으로 정의해두었는데
    다른 좋은 방법 있으시면 말씀해주세여!

@plla2 plla2 requested a review from grapefruit13 January 11, 2025 05:07
@plla2 plla2 self-assigned this Jan 11, 2025
Copy link
Contributor

@grapefruit13 grapefruit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금처럼 네이밍해도 좋을 것 같아여
고생하셨습니다~

@plla2 plla2 merged commit 91d8fce into dev Jan 11, 2025
1 check passed
@plla2 plla2 deleted the THKV-117 branch January 11, 2025 05:16
plla2 added a commit to plla2/NNplanner-FE that referenced this pull request Jan 11, 2025
Fix[THKV-117]: Typography color variants 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants