Skip to content

Conversation

@grapefruit13
Copy link
Contributor

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • InfoCard 리디자인
  • typography variants 수정

설명 (선택)

  • typography variants color에 black 컬러 추가했습니다.
  • dark, darken, gray는 리디자인 컬러 팔레트에 없어서 추후 삭제라고 주석달아두었습니다!

스크린샷

image

리뷰 요구사항

  • ⚠️ 해당 브랜치 먼저 dev에 머지되고 나서 승현님 작업 시작해주세요 (typography 컨플릭트를 피하기 위해)

@grapefruit13 grapefruit13 marked this pull request as ready for review January 10, 2025 12:37
@grapefruit13 grapefruit13 requested a review from plla2 January 10, 2025 12:37
@grapefruit13 grapefruit13 self-assigned this Jan 10, 2025
Copy link
Member

@plla2 plla2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 리디자인 하면서 color에 dark쓴 부분 black으로 수정해야겠군여 color variant 네이밍 맞춰서 수정해두겠습니다~!

@grapefruit13 grapefruit13 merged commit d37b4ca into dev Jan 11, 2025
2 checks passed
@grapefruit13 grapefruit13 deleted the THKV-116 branch January 11, 2025 03:39
plla2 added a commit to plla2/NNplanner-FE that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants