Skip to content

Feat[THKV-115]: Table, TableBody, TableHeader 컴포넌트 리디자인 적용 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grapefruit13 merged 8 commits into from
Jan 10, 2025
Merged

Feat[THKV-115]: Table, TableBody, TableHeader 컴포넌트 리디자인 적용 #110

grapefruit13 merged 8 commits into from
Jan 10, 2025

Conversation

@plla2
Copy link
Member

@plla2 plla2 commented Jan 10, 2025

유형

  • 기능 구현
  • UI 구현
  • 리팩토링
  • 버그 해결
  • 문서 업데이트
  • 기타( )

작업 내용

  • Table, TableBody, TableHeader 컴포넌트 리디자인 적용
  • Pagination 페이지 1개일때의 스타일 수정
  • ControlTab 컴포넌트 ListControls 컴포넌트에서 ViewPlan, ViewChart 각 컴포넌트로 이동

스크린샷

image

image

리뷰 요구사항

  • 식단/설문 테이블별로, cols별로 고정된 너비가 모두 달라서 식단, 설문에 대한 테이블은 planHeaderStyles surveyHeaderStyles 로 선언해서 각 header마다 디자인된 너비를 주었습니다!
  • 영양정보 테이블도 똑같이 headerStyles 선언해서 각 cols마다 너비를 지정해주시고 사용하면 될 것 같습니다

@plla2 plla2 requested a review from grapefruit13 January 10, 2025 06:45
@plla2 plla2 self-assigned this Jan 10, 2025
grapefruit13
grapefruit13 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@grapefruit13 grapefruit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 커멘트 남긴 것 한 번 확인 부탁드려요~

grapefruit13
grapefruit13 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@grapefruit13 grapefruit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@grapefruit13 grapefruit13 merged commit ee90710 into dev Jan 10, 2025
@grapefruit13 grapefruit13 deleted the THKV-115 branch January 10, 2025 11:46
plla2 added a commit to plla2/NNplanner-FE that referenced this pull request Jan 10, 2025
@plla2
Merge pull request devping-kr#110 from devping-kr/THKV-115
a3cacda 
Feat[THKV-115]: Table, TableBody, TableHeader 컴포넌트 리디자인 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grapefruit13 grapefruit13 grapefruit13 approved these changes

Assignees

@plla2 plla2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plla2 @grapefruit13