Skip to content

quote build_name and build_number #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allburov merged 1 commit into from
Aug 27, 2025
+6 −0
Merged

quote build_name and build_number #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions artifactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2953,6 +2953,7 @@ def _get_info(self, build_name, build_number=""):
# maven-demo/1-build-snapshot => maven-demo%2F1-build-snapshot
url = urllib.parse.quote(build_name, safe="")
if build_number:
build_number = urllib.parse.quote(str(build_number), safe="")
url += f"/{build_number}"
return self._get_build_api_response(url)

Expand All @@ -2970,6 +2971,9 @@ def get_build_diff(self, build_name, build_number1, build_number2):
:param build_number2: number of second build to compare
:return: (dict) json response with difference
"""
build_name = urllib.parse.quote(build_name, safe="")
build_number1 = urllib.parse.quote(str(build_number1), safe="")
build_number2 = urllib.parse.quote(str(build_number2), safe="")
url = f"{build_name}/{build_number1}?diff={build_number2}"
return self._get_build_api_response(url)

Expand Down Expand Up @@ -3011,6 +3015,8 @@ def promote_build(
:param fail_fast: fail and abort the operation upon receiving an error. Default: true
:return:
"""
build_name = urllib.parse.quote(build_name, safe="")
build_number = urllib.parse.quote(str(build_number), safe="")
url = f"{self.drive}/api/build/promote/{build_name}/{build_number}"

if not isinstance(properties, dict):
Expand Down