profile added #13
profile added #13
Conversation
lmarniazman
left a comment
lmarniazman
left a comment
There was a problem hiding this comment.
Looks great, thank you! Just a few comments regarding empty lines, if you could adjust those it would be perfect and I can approve.
pom.xml
Outdated
| </execution> | ||
| </executions> | ||
| </plugin> | ||
|
|
There was a problem hiding this comment.
Could you format this so that there is only one empty line between different plugins? Just for consistency
pom.xml
Outdated
| </plugins> | ||
| </build> | ||
| </profile> | ||
|
|
There was a problem hiding this comment.
The other profiles don't have an empty line between them, we should keep it the same way here
| </reporting> | ||
|
|
||
| <profiles> | ||
| <!-- JaCoCo for test coverage --> |
There was a problem hiding this comment.
@hohwille Was this how you meant to include the jacoco-report profile into maven-parent? I thought this was a good way of doing it. After this PR is merged, we can also delete the profile from the pom.xml of sonar-devon4j-plugin.
| <warName>${project.artifactId}</warName> | ||
| </configuration> | ||
| </plugin> | ||
|
|
There was a problem hiding this comment.
I meant that tags on the second level should have one line between them, tags on every other level should not. So if you coud add one empty line between 345-346 that would be great
| </plugin> | ||
| </plugins> | ||
| </reporting> | ||
|
|
There was a problem hiding this comment.
See review comment above, one empty line here between </reporting> and <profiles> would be perfect.
There was a problem hiding this comment.
Thanks @lmarniazman . All comments are fixed.
|
You could really help me by writing a description what is changed by the PR and why in 1-3 sentences. Was this PR done because of devonfw/devon4j#300? |
As @lmarniazman suggestion,Was this how you meant to include the jacoco-report profile into maven-parent. we thought this was a good way of doing it. After this PR is merged, we can also delete the profile from the pom.xml of sonar-devon4j-plugin. |
|
I incorporated the indendation fixes into master. |
3 participants
No description provided.