-
Notifications
You must be signed in to change notification settings - Fork 13
devonfw/ide#1143 Add support for Tomcat #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Leosssss Thanks for your PR. Good work - you got most things correct. 👍
I left comments with explanations what to improve.
tomcat/urls
Outdated
| @@ -0,0 +1 @@ | |||
| https://archive.apache.org/dist/tomcat/tomcat-${major}/v${version}/src/apache-tomcat-${version}-src.${ext} No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to download tomcat manually, unpack and start it?
src stands for source(-code). Therefore this download URL leads to an archive containing the Java source code files of tomcat that need to be compiled and build before you can run them.
You should use bin instead of src and if I am not mistaken, you can use the regular zip distribution of tomcat that can run on all platforms so in ext-mappings you can just have one line *=.zip.
tomcat/available-versions
Outdated
| @@ -0,0 +1 @@ | |||
| 9.0.76 No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you should list all the versions. For major version 9, you can get the list from here:
https://archive.apache.org/dist/tomcat/tomcat-9/ but you can omit the milestones (9.0.0.M*).
devonfw/ide#1143: add tomcat download metadata