#1653 implementation get version and get edition docker #1668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1653
Implemented changes:
getVersion()andgetEdition()forDockeras well askubectlis now working properly on Windows and Linux.Note:
regand checks for installation in windows registryaptand filtered usinggrepPseudocode:
FUNCTION getInstalledVersion():
FUNCTION getInstalledEdition():
Findings about Testcases
Testcases was not yet implemented correctly. The idea that has been tested:
What could work:
DockerTest.javawith path for mockedrdctland bash path* on customenvironment.properties(*hard-coded) .-> getVersion() is working properly.
Still in progress:
Mocking
cmdandregfor checking DockerDesktop version.regmight also be mocked with file with.cmdextension.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal