-
Notifications
You must be signed in to change notification settings - Fork 48
#1646 Implemented check for duplicate versions #1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 20330337112Details
💛 - Coveralls |
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devySingh thanks for analysing, testing, and fixing this bug. Your PR looks good to me 👍
As I wrote, please also add the issue to the CHANGELOG.
Then we can merge.
cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Fix for Issue-Id: 1646 added.
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devySingh excellent. Thanks for the update and completing your work nicely. 👍
Ready for merge.
This PR fixes #1646
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal