Skip to content

Conversation

@devySingh
Copy link
Contributor

@devySingh devySingh commented Dec 16, 2025

This PR fixes #1646

Implemented changes:

  • Implemented a check for duplicate tool versions inside for loop, so that the loop skips iterating if no new versions are available.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Collaborator

coveralls commented Dec 16, 2025

Pull Request Test Coverage Report for Build 20330337112

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 70.088%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ToolCommandlet.java 38 75.56%
Totals Coverage Status
Change from base Build 20330220431: 0.001%
Covered Lines: 10188
Relevant Lines: 13961

💛 - Coveralls

@devySingh devySingh requested a review from hohwille December 16, 2025 15:28
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devySingh thanks for analysing, testing, and fixing this bug. Your PR looks good to me 👍
As I wrote, please also add the issue to the CHANGELOG.
Then we can merge.

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in IDEasy board Dec 16, 2025
@hohwille hohwille added this to the release:2025.12.001 milestone Dec 16, 2025
@hohwille hohwille added security CVEs or other vulnerabilities install installation process of IDE + tools and install commandlet bugfix PR that fixes a bug issue labels Dec 16, 2025
devySingh and others added 2 commits December 17, 2025 10:03
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Fix for Issue-Id: 1646 added.
@devySingh devySingh requested a review from hohwille December 17, 2025 09:16
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devySingh excellent. Thanks for the update and completing your work nicely. 👍
Ready for merge.

@hohwille hohwille merged commit 73fa023 into devonfw:main Dec 18, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet security CVEs or other vulnerabilities

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Duplicated options from CVE update suggestion

3 participants