Skip to content

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Dec 15, 2025

This PR fixes #1644

Implemented changes:

  • added PypiObjectJsonDeserializer
  • registered in JsonMapping
  • simplified our Java model PypiObject to the minimum we really need.
  • added tests

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2025.12.001 milestone Dec 15, 2025
@hohwille hohwille self-assigned this Dec 15, 2025
@hohwille hohwille added pip Python package manager (Pip Installs Packages) native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI) bugfix PR that fixes a bug issue json labels Dec 15, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Dec 15, 2025
@hohwille
Copy link
Member Author

[ERROR] TomcatUrlUpdaterTest.testTomcatUrlUpdaterCreatesDownloadUrlsAndChecksums:41 » IllegalState Error while getting versions from JSON API https://api.github.com/repos/apache/tomcat/git/refs/tags

See #1475 - bug still not fixed. Unplug your network and run TomcatUrlUpdaterTest. This is as nasty as a virus ;)

@hohwille hohwille moved this from 🆕 New to 👀 In review in IDEasy board Dec 15, 2025
@hohwille hohwille added the internal Nothing to be added to CHANGELOG, only internal story label Dec 15, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 20235088356

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.138%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/json/JsonMapping.java 1 93.33%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/tool/repository/PipRepository.java 8 51.85%
Totals Coverage Status
Change from base Build 20115895339: -0.002%
Covered Lines: 10160
Relevant Lines: 13921

💛 - Coveralls

@hohwille hohwille merged commit ab4c5d5 into devonfw:main Dec 15, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue internal Nothing to be added to CHANGELOG, only internal story json native-image GraalVM native image of IDEasy CLI (e.g. for bugs that only happen in binary of CLI) pip Python package manager (Pip Installs Packages)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

pip not working in native-image

2 participants