Skip to content

Conversation

@hkosim
Copy link
Contributor

@hkosim hkosim commented Dec 11, 2025

This PR fixes #1645

Implemented changes:

  • Added hotfix to avoid the NullPointerException when installing docker / kubectl / rancher desktop.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2025

CLA assistant check
All committers have signed the CLA.

@hkosim hkosim requested a review from hohwille December 11, 2025 13:12
@hkosim hkosim self-assigned this Dec 11, 2025
@hkosim hkosim moved this from 🆕 New to Team Review in IDEasy board Dec 11, 2025
@hkosim hkosim added docker docker and esp. DockerDesktop bugfix PR that fixes a bug issue rancher Rancher-Desktop install installation process of IDE + tools and install commandlet and removed docker docker and esp. DockerDesktop labels Dec 11, 2025
@hkosim hkosim requested a review from devySingh December 11, 2025 13:14
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2025

Pull Request Test Coverage Report for Build 20261483189

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 70.142%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ToolCommandlet.java 34 75.97%
Totals Coverage Status
Change from base Build 20241902872: 0.004%
Covered Lines: 10167
Relevant Lines: 13928

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkosim thanks for your first bugfix PR. Now if the ToolEdition is null, the NPE should be fixed. 👍
However, we do not know for sure if not maybe already installed variable was null.
Then we can still get an NPE here.
Also, please add #1645 to our CHANGELOG within this PR.

@github-project-automation github-project-automation bot moved this from Team Review to 👀 In review in IDEasy board Dec 11, 2025
@hohwille hohwille added this to the release:2025.12.001 milestone Dec 16, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkosim thanks for your update. Now everything is bullet-proof and perfect. Thanks 👍
Ready for merge.

@hohwille hohwille merged commit de740df into devonfw:main Dec 16, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet rancher Rancher-Desktop

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

NPE during installation of rancher desktop

4 participants