-
Notifications
You must be signed in to change notification settings - Fork 48
#1166: import maven repos in intellij by editing misc.xml #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1166: import maven repos in intellij by editing misc.xml #1466
Conversation
Pull Request Test Coverage Report for Build 19833443579Details
💛 - Coveralls |
|
Gradle projects are automatically imported if a valid gradle.xml file is found in .idea. I'll follow the same approach as for the misc.xml to automatically create / update this file if a build.gradle file is found. |
…mport-for-intellij' into feature/1166-automatic-project-import-for-intellij
…mport-for-intellij' into feature/1166-automatic-project-import-for-intellij
…mport-for-intellij' into feature/1166-automatic-project-import-for-intellij
…stractEnvironmentVariables
hohwille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cthies-capgemini thanks for your PR. Great that you found the proper solutions to import projects for maven and gradle. Also your implementation is looking good. 👍
However, I found some things that need further improvements before we can merge.
Also it would be great to always have a JUnit for each relevant feature we add.
cli/src/main/java/com/devonfw/tools/ide/environment/ExtensibleEnvironmentVariables.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/environment/ExtensibleEnvironmentVariables.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/environment/ExtensibleEnvironmentVariables.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
…EnvironmentVariables.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
added constants and replaced fixed strings enhanced debug messages with missing file paths
refactored mergeMisc and mergeGradle into mergeConfig method
cli/src/main/java/com/devonfw/tools/ide/tool/intellij/Intellij.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/environment/ExtensibleEnvironmentVariables.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/environment/ExtensibleEnvironmentVariables.java
Show resolved
Hide resolved
extended ExtensibleEnvironmentVariables from EnvironmentVariablesMap added findAncestoryWithFolder to FileAccess added findAncestoryWithFolder added tests of findAncestoryWithFolder to FileAccessImplTests added test of intellij project import to IntellijTest added test resources to simulate a repository import of intellij added createValidEmptyXmlFile to XmlMerger (to be able to handle missing files) removed temporary workaround in Intellij for the creation of an empty xml file
Added entry for automatic project import feature in IntelliJ.
|
Replaced by PR #1649 |
This PR fixes #1166 .
Implemented changes:
For Maven:
This is the current content of the template misc.xml:
For Gradle
Implementations by @jan-vcapgemini:
This is the current content of the template gradle.xml:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal