#5: implement thirdparty violations

pom.xml

@@ -101,7 +101,16 @@
       <scope>provided</scope>
       <version>${querydsl.version}</version>
     </dependency>
-
+    <dependency>
+      <groupId>org.hibernate</groupId>
+      <artifactId>hibernate-envers</artifactId>
+      <version>6.1.7.Final</version>
+    </dependency>
+    <dependency>
+      <groupId>org.springframework</groupId>
+      <artifactId>spring-tx</artifactId>
+      <version>5.3.20</version>
+    </dependency>
     <!-- Test -->
     <dependency>
       <groupId>io.quarkus</groupId>

src/main/java/com/devonfw/sample/archunit/thirdparty/E3ViolationThirdpartyLayerDependsOnJpaOutsideOfDataaccessLayer.java

@@ -0,0 +1,8 @@
+package com.devonfw.sample.archunit.thirdparty;
+
+import javax.persistence.EntityManager; // Noncompliant
+
+public class E3ViolationThirdpartyLayerDependsOnJpaOutsideOfDataaccessLayer {
+    // Noncompliant
+    private EntityManager entityManager;
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/E4ViolationThirdpartyLayerDependsOnHibernateOutsideOfDataaccessLayer.java

@@ -0,0 +1,13 @@
+package com.devonfw.sample.archunit.thirdparty;
+
+import java.util.HashSet;
+import java.util.Set;
+
+import org.hibernate.Session; //Noncompliant
+import org.hibernate.annotations.OrderBy; //Noncompliant
+
+public class E4ViolationThirdpartyLayerDependsOnHibernateOutsideOfDataaccessLayer {
+    @OrderBy(clause = "NAME DESC") // Noncompliant
+    Set<String> taskList = new HashSet<>();
+    Session session; //Noncompliant
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/E1ViolationThirdpartyLayerDependsOnDiscouragedTransactionalAnnotation.java

@@ -0,0 +1,8 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess;
+
+import org.springframework.transaction.annotation.Transactional; // Noncompliant the use of JEE standard javax.transaction.Transactional is encouraged.
+
+@Transactional
+public class E1ViolationThirdpartyLayerDependsOnDiscouragedTransactionalAnnotation {
+
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/api/E4ViolationThirdpartyLayerDependsOnHibernateInsideApiLayer.java

@@ -0,0 +1,7 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess.api;
+
+import org.hibernate.Session; // Noncompliant
+
+public class E4ViolationThirdpartyLayerDependsOnHibernateInsideApiLayer {
+    Session sessionFactory;
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/impl/E4HibernatePositiveExample.java

@@ -0,0 +1,10 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess.impl;
+//The use is compliant because it lies inside dataaccess/impl
+import org.hibernate.Session; //compliant 
+import org.hibernate.envers.Audited;
+
+public class E4HibernatePositiveExample {
+    @Audited
+    Long id;
+    Session session;
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/impl/E4ViolationThirdpartyLayerDependsOnDiscouragedHibernateAnnotation.java

@@ -0,0 +1,11 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess.impl;
+
+import org.hibernate.annotations.Entity; // Noncompliant
+
+public class E4ViolationThirdpartyLayerDependsOnDiscouragedHibernateAnnotation {
+    // Noncompliant
+    @Entity
+    class NoncompliantInnerClass{
+
+    }
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/impl/E4ViolationThirdpartyLayerDependsOnHibernateEnversInternalsDirectly.java

@@ -0,0 +1,8 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess.impl;
+
+import org.hibernate.envers.query.internal.impl.EntitiesAtRevisionQuery; // Noncompliant
+
+public class E4ViolationThirdpartyLayerDependsOnHibernateEnversInternalsDirectly {
+    //Noncompliant
+    EntitiesAtRevisionQuery nonCompliantDirectQuery = new EntitiesAtRevisionQuery(null, null, getClass(), null, false);
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/dataaccess/misc/E4ViolationThirdPartyLayerDependsOnHibernateEnversOutsideOfImplLayer.java

@@ -0,0 +1,8 @@
+package com.devonfw.sample.archunit.thirdparty.dataaccess.misc;
+
+import org.hibernate.envers.Audited; // Noncompliant
+
+public class E4ViolationThirdPartyLayerDependsOnHibernateEnversOutsideOfImplLayer {
+    @Audited
+    String name;
+}

src/main/java/com/devonfw/sample/archunit/thirdparty/service/api/E1ViolationThirdpartyLayerDependsOnJavaxTransactionalInApiLayer.java

@@ -0,0 +1,8 @@
+package com.devonfw.sample.archunit.thirdparty.service.api;
+
+import javax.transaction.Transactional; // Noncompliant
+
+@Transactional
+public class E1ViolationThirdpartyLayerDependsOnJavaxTransactionalInApiLayer {
+
+}