practice-js-basics done #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmentor-pl
approved these changes
Jun 23, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Michale,
Zadania są ok 👍
Zostawiłem Ci parę uwag, na spotkaniu wszystko dokładnie umówimy :)
| } | ||
|
|
||
| console.log(); | ||
| console.log(); |
02/app.js
Outdated
|
|
||
| while (j <= n) { | ||
| if (a <= 9 && a > 0 && n <= 9 && n > 0) { | ||
| result2 = Math.pow(a, n); |
Owner
There was a problem hiding this comment.
Trochę inaczej miało się to wyświetlać w konsoli :)
| } | ||
| } | ||
|
|
||
| showInfo(sum, even); |
| sum += num; | ||
|
|
||
| }); | ||
| return sum / arr.length; |
Owner
There was a problem hiding this comment.
Warto się zabezpieczyć czy nie dzielimy przez 0 :)
05/app.js
Outdated
| for (let i = 0; i < grades.length; i++) { | ||
| sum += grades[i]; | ||
| } | ||
| console.log(sum / grades.length); |
Owner
There was a problem hiding this comment.
Tutaj powinno być return, bo funkcja powinna zwrócić wynik (zaczyna się od get)
05/app.js
Outdated
| } | ||
| if (totalCount === 0) return null; | ||
|
|
||
| console.log((totalSum / totalCount).toFixed(2)); |
Comment on lines
41
to
44
| for (let subjectName in this.grades) { | ||
| const subjectGrades = this.grades[subjectName]; | ||
|
|
||
| for (let i = 0; i < subjectGrades.length; i++) { |
Owner
There was a problem hiding this comment.
To jest to oczym pisałem na Slacku. Pobieramy konkretny przedmiot oraz oceny dla niego. Sumujemy i pobieramy oceny dla kolejnego - w ten sposób mamy dostęp do wszystkich ocen (a w zasadzie ich sumy) i możęmy obliczyć średnią.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.