practice-js-basics done #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmentor-pl
approved these changes
Apr 7, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Neil,
Wszystko wygląda bardzo dobrze! 👍
Zostawiłem jedynie drobne usprawnienie w zadaniu 05 :)
| } | ||
| function textLess(num) { | ||
| console.log(`${num} is less then 20.`); | ||
| } |
| str += ` * ${a}`; | ||
| result *= a; | ||
| } | ||
| console.log(`${str} = ${result}`); |
| default: | ||
| console.log(`Podany argument ${num} nie jest liczbą`); | ||
| } | ||
| } |
| const largest = getLargest(newArr); | ||
| console.log(largest); | ||
| const avg = getAvg(largest); | ||
| console.log(avg); |
| allGrades.push(...this.grades[subject]); | ||
| } | ||
| return ( | ||
| allGrades.reduce((acc, val) => acc + val) / allGrades.length |
Owner
There was a problem hiding this comment.
Zwróć uwagę, że ta część jest dość podobna do tej z linii 28-29, może warto napisać metodę (funkcje z wykorzystniem prototype) i wykorzystać ją w obu miejscach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.