done #160
Open
done #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmentor-pl
approved these changes
Apr 2, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Dario,
Całość wygląda bardzo dobrze 👍
Zostawiłem Ci dodatkowe działanie dla zadanie 05 :)
Comment on lines
+10
to
+15
| const suma = numA + b; | ||
| const roznica = numA - b; | ||
| const iloczyn = numA * b; | ||
| const iloraz = numA / b; | ||
| const modulo = numA % b; | ||
| const potega = numA ** b; |
Owner
There was a problem hiding this comment.
Nazwy zmiennych zdecydowanie lepiej jest pisać w j. angielskim
| } | ||
| } else { | ||
| alert('Podałeś dane poza zakresem!'); | ||
| } |
Comment on lines
+11
to
+13
| a = Math.floor(Number(a)); | ||
| b = Math.floor(Number(b)); | ||
| c = Math.floor(Number(c)); |
Owner
There was a problem hiding this comment.
Można też utworzyć tablicę, posortować i mamy 2 największe liczby troszkę prościej :)
| if (arr.length === 0) return 0; | ||
| const sum = arr.reduce((acc, num) => acc + num, 0); | ||
| return sum / arr.length; | ||
| } |
05/index.js
Outdated
Comment on lines
29
to
32
| const sum = grades.reduce(function (acc, curr) { | ||
| return acc + curr; | ||
| }, 0); | ||
| return sum / grades.length; |
Owner
There was a problem hiding this comment.
Ta część jest bardzo podobna do części z linii 39-43 - w takim wypadku warto zrobić metodę (funkcje) i w obu miejscach wykorzystać, spróbujesz?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.