done #154
Open
done #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmentor-pl
approved these changes
Nov 25, 2024
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Marku,
Rozwiązania są jak najbardziej ok!
Zostawiłem parę drobnych uwag ;)
| } | ||
| }); | ||
|
|
||
|
|
| const n = parseInt(prompt('Podaj wykłądnik potęgi: ')); | ||
|
|
||
| if(n >= 1) { | ||
| let result = 1; let i = 0; let formula = ''; |
Owner
There was a problem hiding this comment.
Jeśli chcesz napisać w jednym wierszu to lepiej zrobić to tak:
let result = 1, i = 0, formula = '';
Comment on lines
+20
to
+29
| const max1 = Math.max(num1, num2, num3); | ||
|
|
||
| let max2; | ||
| if (max1 === num1) { | ||
| max2 = Math.max(num2, num3); | ||
| } else if (max1 === num2) { | ||
| max2 = Math.max(num1, num3); | ||
| } else { | ||
| max2 = Math.max(num1, num2); | ||
| } |
Owner
There was a problem hiding this comment.
Można też utworzyć tablicę i wykorzystać sort - wtedy największe są dwie pierwsze lub dwie ostatnie ;)
|
|
||
| const sum = getSum(a, b, c); | ||
| const even = isEven(sum); | ||
| showInfo(sum, even); |
Comment on lines
+18
to
+20
| const sum = arr.reduce((acc, num) => acc + num, 0); | ||
|
|
||
| return sum / arr.length; |
Owner
There was a problem hiding this comment.
Warto sprawdzić czy tablice nie jest pusta, aby nie dzielić przez 0 :)
Comment on lines
+25
to
+26
| const sum = grades.reduce((acc, grade) => acc + grade, 0); | ||
| return sum / grades.length; |
Owner
There was a problem hiding this comment.
Zwróć uwagę, że ten kod powtarza się z tym z linii 32-33 - może warto napisać funkcję, która zostanie wykorzystana w obu miejscach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.