Zadania #153
Open
Zadania #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmentor-pl
approved these changes
Nov 18, 2024
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Piotrze,
Zostawiłem Ci parę drobnych uwag - poza tym ok! 👍
Comment on lines
+12
to
+15
| const difference = Number(a) - b; | ||
| const multiplication = Number(a) * b; | ||
| const division = Number(a) / b; | ||
| const modulo = Number(a) % b; |
Owner
There was a problem hiding this comment.
Warto też sprawdzić czy konwersja jest tutaj niezbędna.
| } | ||
| } | ||
| console.log(str); | ||
| console.log(str+'='+result); |
| } | ||
| const itResult = isEven(result); | ||
|
|
||
| showInfo(result, itResult); |
| const sum = arr.reduce(function (accumulator, currentValue) { | ||
| return accumulator + currentValue; | ||
| }, 0); | ||
| return sum / arr.length; |
Owner
There was a problem hiding this comment.
Warto sprawdzać czy tablica posiada jakieś elementy, bo wtedy dzielimy przez 0 :P
Comment on lines
+9
to
+10
| } | ||
| this.grades[subject].push(grade); |
Owner
There was a problem hiding this comment.
Uwaga na odstępy od lewej krawędzi
| return acc + grade; | ||
| }, 0); | ||
|
|
||
| return sum / grades.length; |
Owner
There was a problem hiding this comment.
Podobnie jak w poprzednim zadaniu - nie dzielimy przez 0 :P
| const avg = student.getAverageGrade(); | ||
|
|
||
| console.log(avgMath); | ||
| console.log(avg); No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.