[pull] master from Bash-it:master #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSH completion was removing the @ sign when completing user@host combinations. For example, `ssh root@ser<TAB>` would complete to `ssh rootserver` instead of `ssh root@server`. **Root Cause:** The @ character was in COMP_WORDBREAKS, causing bash to treat it as a word boundary and remove it during completion. **Solution:** Remove @ from COMP_WORDBREAKS (in addition to : which was already removed). This allows the completion to preserve the full user@host format. **Testing:** - Passes shellcheck with no warnings - Passes shfmt formatting checks - Completion now correctly preserves user@host format Closes #2260 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ersion Adds the ability to only show node version in the prompt when inside a Node.js project (detected by presence of package.json). **Problem:** The node version was always displayed in the prompt regardless of the current directory context. This wastes space when working on non-Node.js projects (Python, Ansible, etc.). **Solution:** - New environment variable: `NODE_VERSION_CHECK_PROJECT` (default: false) - When set to 'true', node version only shows in directories with package.json - Searches current directory and parent directories up to $HOME - Applies to all node version display strategies (nvm, node, command) **Usage:** ```bash # Add to ~/.bashrc or ~/.bash_profile before sourcing bash-it export NODE_VERSION_CHECK_PROJECT=true ``` **Implementation:** - New helper function `_is_node_project()` checks for package.json - Modified `node_version_prompt()` to check NODE_VERSION_CHECK_PROJECT - Modified `node_command_version_prompt()` for consistency - Backwards compatible (disabled by default) **Testing:** - Passes shellcheck with no warnings - Passes shfmt formatting checks - Maintains backward compatibility Closes #2216 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Use character class syntax [:@] to remove both characters in one operation as suggested by @akinomyoga in review. Co-Authored-By: akinomyoga <akinomyoga@users.noreply.github.com>
Add explicit return code 0 to all return statements as suggested by @akinomyoga to avoid strange behaviors in trap handlers. Co-Authored-By: akinomyoga <akinomyoga@users.noreply.github.com>
Updates all remaining test file references to reflect the rename from todo.txt-cli.aliases.bash to todo.aliases.bash. This completes the consistency improvements started in the main PR. Changes: - Updated test names to use "todo" instead of "todo.txt-cli" - Updated symlink paths in test setup - Updated assertions to expect new filename - All 69 tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
* master: Fix symlink handling in uninstall backup Update planning docs with completed issues and PRs Improve uninstall script to preserve current config before restoration Fix down4me function URL malformation issue Apply review feedback: use git --git-dir and simplify awk Add comprehensive issue analysis and 2025 roadmap documentation Fix remote name detection function Add heuristic for finding default remote name
Update test expectations to use priority 750 (default for aliases) instead of 150. The todo.aliases.bash file doesn't specify a custom priority, so it uses BASH_IT_LOAD_PRIORITY_ALIAS which defaults to 750. Changes: - Updated helpers.bats test expectations from 150 to 750 - Updated completion tests from 150 to 750 - All 69 helpers tests now pass - All 46 completion tests now pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )