Pin the parent Devfile version to 1.2.0#36
Merged
thepetk merged 2 commits intodevfile-samples:mainfrom Oct 20, 2023
Merged
Conversation
The default version of the parent Stack will be updated in [1] to use JDK 17, so that users on recent versions of Spring Boot can use such Stack. This is to make sure this sample does not break with such change, and continues to work as before, since it is using Sprint Boot 2.x (and expects JDK 11). Signed-off-by: Armel Soro <asoro@redhat.com>
Recent versions of odo add additional files to this folder. Signed-off-by: Armel Soro <asoro@redhat.com>
Contributor
Author
|
@thepetk PTAL at this PR following our discussion. I've tested this with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default version of the parent Stack will be updated in [1] to use JDK 17,
so that users on recent versions of Spring Boot can use such Stack.
This PR is to make sure this sample does not break with such a change,
and continues to work as before, since it is still using Sprint Boot 2.x.
[1] devfile/registry#169