[DO NOT MERGE] Update port from 8081 to 8080#33
Open
maysunfaisal wants to merge 7 commits intodevfile-samples:mainfrom
Open
[DO NOT MERGE] Update port from 8081 to 8080#33maysunfaisal wants to merge 7 commits intodevfile-samples:mainfrom
maysunfaisal wants to merge 7 commits intodevfile-samples:mainfrom
Conversation
Contributor
maysunfaisal
commented
Jul 10, 2023
maysunfaisal
commented
- Updates the devfile sample port from 8081 to 8080
- Doesnt update the attribute alpha.dockerimage-port: 8081 because of backward compatibility in ODC earlier versions. We dont want to backport devfile/library update that far back.
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Contributor
|
@maysunfaisal I've updated the base of the PR to point to the branch I've also added WIP as we need first to merge devfile/registry#219 |
thepetk
changed the title
Contributor
|
fixes devfile/api#1112 |
Signed-off-by: thepetk <thepetk@gmail.com>
4 tasks
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
changed the title
Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
changed the title
Contributor
|
@maysunfaisal any chance we could revisit this one and either merge or close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.