Adding MUI font and icons to index.html #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Learn how to configure a non-root public URL by running `npm run build`. | ||
| --> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&display=swap" /> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons" /> |
Member
There was a problem hiding this comment.
I am honestly a little torn on this. This is super simple but does have the potential disadvantage that we are dependent on the external cdn for the app to look right (google should be up but what if it isn't).
Thoughts on using something like this https://github.com/fontsource/fontsource to include these fonts in the bundle?
//fonts.ts
import "fontsource-roboto";
import "fontsource-material-icons";
theme.ts
import "./fonts";
// do material theme things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialUI by default uses Roboto and the Material Icons. This change introduces those two resources to the template index.html.