fix(pptx): skip master/layout placeholders, render custGeom, fix wrap and list numbering#171
Merged
developer0hye merged 3 commits intomainfrom Mar 14, 2026
Merged
Conversation
… and list numbering - Skip shapes with <p:ph> when parsing master/layout layers so placeholder text (e.g. "마스터 제목 스타일 편집") is not rendered - Handle self-closing <p:ph/> in handle_empty as well as handle_start - Treat <a:custGeom> as rect fallback so custom geometry fills render - Parse bodyPr wrap="none" attribute and use context+measure() to auto-size text box width, preventing last-character line wrapping caused by font metric differences with substitute fonts - Fix enum numbering: use (..nums) variadic parameter capture instead of plain nums to prevent "cannot spread integer" Typst error Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<p:ph>when parsing master/layout layers to prevent placeholder text from rendering (e.g. "마스터 제목 스타일 편집")<p:ph/>inhandle_empty(previously only handled inhandle_start)<a:custGeom>as rectangle fallback so custom geometry shapes with fills render correctly<a:bodyPr wrap="none"/>and use#context+measure()to auto-size text box width, preventing last-character wrapping from font metric differences#enumnumbering: use(..nums)variadic parameter capture instead ofnumsto prevent "cannot spread integer" Typst compilation errorTest plan
🤖 Generated with Claude Code