Skip to content

Conversation

@miaulightouch
Copy link

@miaulightouch miaulightouch commented Sep 14, 2023

It fixed the path if the packages contain CLI binaries, causing pnpm/yarn to have a different folder structure than normal packages.

  • normal package:
    • node_modules/axios -> node_modules/.pnpm/axios@1.3.3/node_modules
  • package that contains cli:
    • node_modules/electron-updater -> node_modules/.pnpm/electron-updater@5.3.0/node_modules /electron-updater/node_modules
    • the dependency builder-util-runtime is placed in node_modules/.pnpm/electron-updater@5.3.0/node_modules
    • this fix reports node_modules/.pnpm/electron-updater@5.3.0/node_modules

I'm not familiar with Go, but it seems to work.

However, there is another issue that arises in 'app-builder-lib': the root 'node_modules' should create the same symlink folder structure instead of copying the dependencies.

While it doesn't solve #92, it can serve as a starting point.

@mmaietta
Copy link
Collaborator

CI test is failing, please take a look when you have a chance

Error: pkg/node-modules/nodeModuleCollector.go:280:9: undefined: slices

@sevenc-nanashi
Copy link

Any updates on this PR?
I think adding "golang.org/x/exp/slices" to imports will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants