Skip to content

🚨 [security] Update puma: 4.3.5 → 4.3.8 (patch)#352

Closed
depfu[bot] wants to merge 1 commit intodevelopfrom
depfu/update/puma-4.3.8
Closed

🚨 [security] Update puma: 4.3.5 → 4.3.8 (patch)#352
depfu[bot] wants to merge 1 commit intodevelopfrom
depfu/update/puma-4.3.8

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented May 20, 2021


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ puma (4.3.5 → 4.3.8) · Repo · Changelog

Security Advisories 🚨

🚨 Keepalive Connections Causing Denial Of Service in puma

Impact

The fix for CVE-2019-16770 was incomplete. The original fix only protected
existing connections that had already been accepted from having their
requests starved by greedy persistent-connections saturating all threads in
the same process. However, new connections may still be starved by greedy
persistent-connections saturating all threads in all processes in the
cluster.

A puma server which received more concurrent keep-alive connections than the
server had threads in its threadpool would service only a subset of
connections, denying service to the unserved connections.

Patches

This problem has been fixed in puma 4.3.8 and 5.3.1.

Workarounds

Setting queue_requests false also fixes the issue. This is not advised when
using puma without a reverse proxy, such as nginx or apache, because you will
open yourself to slow client attacks (e.g. slowloris).

The fix is very small. A git patch is available here for those using
unsupported versions of Puma.

Release Notes

4.3.8

  • Security
    • Close keepalive connections after the maximum number of fast inlined requests (#2625)

4.3.7 (from changelog)

  • Bugfixes
    • Backport set CONTENT_LENGTH for chunked requests (Originally: #2287, backport: #2496)

4.3.6

v4.3.5...4.3.6

A quick fix for a build error on Mac OS and a JSON require fix for those using phased restart.

  • Explicitly include ctype.h to fix compilation warning and build error on macOS with Xcode 12 (#2304)
  • Don't require json at boot (#2269)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 9 commits:

↗️ nio4r (indirect, 2.5.2 → 2.5.7) · Repo · Changelog

Release Notes

2.5.4 (from changelog)

2.5.3 (from changelog)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 72 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 20, 2021
@depfu
Copy link
Contributor Author

depfu bot commented Oct 12, 2021

Closed in favor of #362.

@depfu depfu bot closed this Oct 12, 2021
@depfu depfu bot deleted the depfu/update/puma-4.3.8 branch October 12, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants