Bump multer dependency to 1.4.5-lts.1#492
Open
zoeesilcock wants to merge 1 commit intodevconcept:masterfrom
Open
Bump multer dependency to 1.4.5-lts.1#492zoeesilcock wants to merge 1 commit intodevconcept:masterfrom
zoeesilcock wants to merge 1 commit intodevconcept:masterfrom
Conversation
This is meant to deal with CVE-2022-24434 and should also fix devconcept#490.
redimongo
approved these changes
Jun 28, 2022
|
Please can someone approve this :) |
|
Can this be merged please? |
sudipta9
approved these changes
Oct 5, 2022
0xsagar
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to deal with CVE-2022-24434 and should also fix #490.
PR Checklist
Verify that you did the following:
Related issue
Issue: #490
Describe what you did
Bumped the
multerdependency to version1.4.5-lts.1in order to solve the CVE-2022-24434 security warning and handle #490. The new version is technically a major bump since it changes the required NodeJS version from>= 0.10.0to>= 6.0.0. That shouldn't be an issue since this package already requires>= 12. Please see the following issue on multer for more information.Is this a breaking change?
I don't think so, but it could affect users that have older versions of
multer. NPM 8 will probably give the same error as in #490 if the user updatesmulter-gridfs-storagewithout updatingmulteralso. This can happen automatically when using^5.0.2as the version formulter-gridfs-storagefor example. Perhapsmulter-gridfs-storageneeds more than a patch version bump to avoid this?