Skip to content

Update diagnostics to change severity from Error to Warning for plugin checks. Closes #219 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrytrinder merged 1 commit into from
Mar 23, 2025
Merged

Update diagnostics to change severity from Error to Warning for plugin checks. Closes #219 #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed:

- Command: Refactored stop command logic
- Diagnostics: Changed check to ensure at least one plugin from Error to Warning

## [0.18.3] - 2025-03-03

Expand Down
4 changes: 2 additions & 2 deletions src/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const checkAtLeastOneEnabledPlugin = (pluginNodes: parse.ObjectNode[], diagnosti
new vscode.Diagnostic(
getRangeFromASTNode(pluginsNode),
'Add at least one plugin',
vscode.DiagnosticSeverity.Error
vscode.DiagnosticSeverity.Warning
)
);
} else {
Expand All @@ -199,7 +199,7 @@ const checkAtLeastOneEnabledPlugin = (pluginNodes: parse.ObjectNode[], diagnosti
new vscode.Diagnostic(
getRangeFromASTNode(pluginsNode),
'At least one plugin must be enabled',
vscode.DiagnosticSeverity.Error
vscode.DiagnosticSeverity.Warning
)
);
}
Expand Down