Skip to content

update: use UpperCamelCase for iserialize type checks in C++ code gen… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RavenX8 merged 1 commit into from
Feb 9, 2026
Merged

update: use UpperCamelCase for iserialize type checks in C++ code gen… #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions generator/src/codegen/cpp/codegen_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
read_write.clone()
} else if let Some(ref enum_type) = elem.enum_type() {
enum_type.clone()
} else if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) {
} else if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) {
"iserialize".to_owned()
} else {
clean_base(elem.type_())
Expand Down Expand Up @@ -232,7 +232,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
if let Some(ref size) = elem.size_occurs() {
cg!(self, "size += sizeof({}); // {}", size, elem.name());
}
let rhs = if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) && elem.enum_type().is_none() {
let rhs = if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) && elem.enum_type().is_none() {
format!("{}::size()", elem.type_())
} else {
let rhs = elem.bitset().as_ref().map_or(Some(format!("sizeof({})", elem.type_())), |bitset| if bitset.start == 0 {
Expand Down Expand Up @@ -443,7 +443,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
if elem.type_() == "std::string" {
continue;
}
let rhs = if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) {
let rhs = if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) {
format!("{}::size()", elem.type_())
} else {
let rhs = elem.bitset().as_ref().map_or(Some(format!("sizeof({})", elem.type_())), |bitset| if bitset.start == 0 {
Expand Down Expand Up @@ -739,7 +739,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
read_write.clone()
} else if let Some(ref enum_type) = elem.enum_type() {
enum_type.clone()
} else if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) {
} else if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) {
"iserialize".to_owned()
} else {
clean_base(elem.type_())
Expand Down Expand Up @@ -799,7 +799,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
for elem in packet.elements() {
let base = if let Some(ref enum_type) = elem.enum_type() {
enum_type.clone()
} else if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) {
} else if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) {
"iserialize".to_owned()
} else {
clean_base(elem.type_())
Expand Down Expand Up @@ -865,7 +865,7 @@ impl<'a, W: Write> CodeSourceGenerator<'a, W> {
for elem in packet.elements() {
let base = if let Some(ref enum_type) = elem.enum_type() {
enum_type.clone()
} else if iserialize.contains(&elem.type_().to_owned().to_lower_camel_case()) {
} else if iserialize.contains(&elem.type_().to_owned().to_upper_camel_case()) {
"iserialize".to_owned()
} else {
clean_base(elem.type_())
Expand Down