Skip to content

Conversation

@AndresMartin510
Copy link
Collaborator

No description provided.

Copy link
Contributor

@francisli francisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donor related CRUD seems to be working well, but the Student form is a bit broken, and NonProfitPartner seems still unfinished...

</div>
<div className="mb-3">
<label className="form-label">Student Comfirmed?</label>
<input className="form-control" type="text" name="Confirm" value={anStudent.confirm} onChange={onChange} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing the form is not working...

Make sure that the name attribute and the variable name in the student object match EXACTLY for the code to work... you see they don't match between userEducation/userEdu and Confirm/confirm...

They should match exactly how they are named in the Student model.

import { useHistory, useParams} from "react-router-dom";
import Api from "../Api";

function StudentsForm() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of this file and component should really be StudentForm (singular Student)... this form edits ONE student, not multiple...

Copy link
Collaborator

@cesar-ca cesar-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is looking great! Amazing job

[Do not merge yet]

@cesar-ca cesar-ca changed the title Andres donor branch 3 feat(Donor setup after sign up): [FAIR-1] May 27, 2021
Copy link
Collaborator

@cesar-ca cesar-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants