add eventing to features to allow for better performance in branch lookups#1
Open
ihildebrandt wants to merge 1 commit intodev-informatics:masterfrom
Open
add eventing to features to allow for better performance in branch lookups#1ihildebrandt wants to merge 1 commit intodev-informatics:masterfrom
ihildebrandt wants to merge 1 commit intodev-informatics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added basic eventing in order to handle name updates on features/branches. That way I was able to remove the .Trim().ToLower() from name lookups.
The trim is now handled in the set{} on the feature and the ToLower is not necessary because I switched from a list to a dictionary with an ignorecase comparer.
If a feature name is changed it is pulled and re-added to the dictionary by the feature-changed event.
IMO, eventing can be used extensively in this project to handle branch changes on the fly.