Open
Conversation
- GPL statement added to all source files.
A few miss still there for director regex.. Also regex must be improved for this kind of records: Warman, Bernardo (I) Dragonboy (2011)
...by converting line endings to unix endings
- a new db class waits us. it can create new tables and inserts data - tests for db class added - readme updated. psycopg2 added as requirement
* removed old comments and TODOs * added a few docs
…ch file to create now
make use of processed versions of parameters where available instead of raw versions directly from argument list
* added endOfDumpDelimiter abstract property to BaseParser - Some dump files has comments at the end of the dump as well as at the start. Comments at the start are avoided by numberOfLinesToBeSkipped property and comments at the end are avoided by endOfDumpDelimiter property. - endOfDumpDelimiter property is used for stoppping parsing of associated file when encountered. Hence indicates end of the dump. For each file this may be different or non-exist at all.
- readme updated - sql dump for movies finished - db removed from modes. we're just creating sql or tsv files
Fixed path string building
Necessary line is still inside the baseparser.py file. If you want to see process of parsing, you can uncomment out that line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://github.com/destan/imdb-data-parser/