Skip to content

Reduce logging to lvl 1 for peer connect/disconnect #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazynina merged 2 commits into from
Jul 1, 2025
Merged

Reduce logging to lvl 1 for peer connect/disconnect #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27f8435
Reduce logging to lvl 1 for peer connect/disconnect
lazynina Jun 30, 2025
15cd57c
lvl 1 instead of 2 for local vote and timeout events
lazynina Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ func (pp *Peer) cleanupMessageProcessor() {

// We assume that no more elements will be added to the message queue once this function
// is called.
glog.Infof("StartDeSoMessageProcessor: Cleaning up message queue for peer: %v", pp)
glog.V(1).Infof("StartDeSoMessageProcessor: Cleaning up message queue for peer: %v", pp)
pp.messageQueue = nil
// Set a few more things to nil just to make sure the garbage collector doesn't
// get confused when freeing up this Peer's memory. This is to fix a bug where
Expand All @@ -579,11 +579,11 @@ func (pp *Peer) cleanupMessageProcessor() {

func (pp *Peer) StartDeSoMessageProcessor() {
pp.startGroup.Done()
glog.Infof("StartDeSoMessageProcessor: Starting for peer %v", pp)
glog.V(1).Infof("StartDeSoMessageProcessor: Starting for peer %v", pp)
for {
if pp.disconnected != 0 {
pp.cleanupMessageProcessor()
glog.Infof("StartDeSoMessageProcessor: Stopping because peer disconnected: %v", pp)
glog.V(1).Infof("StartDeSoMessageProcessor: Stopping because peer disconnected: %v", pp)
return
}
msgToProcess := pp.MaybeDequeueDeSoMessage()
Expand Down Expand Up @@ -1267,7 +1267,7 @@ out:
}

func (pp *Peer) Start() {
glog.Infof("Peer.Start: Starting peer %v", pp)
glog.V(1).Infof("Peer.Start: Starting peer %v", pp)
// The protocol has been negotiated successfully so start processing input
// and output messages.
pp.startGroup.Add(4)
Expand Down Expand Up @@ -1362,7 +1362,7 @@ func (pp *Peer) ReadDeSoMessage() (DeSoMessage, error) {
// Disconnect closes a peer's network connection.
func (pp *Peer) Disconnect(reason string) {
// Only run the logic the first time Disconnect is called.
glog.V(0).Infof(CLog(Yellow, "Peer.Disconnect: Starting for Peer %v with reason: %v"), pp, reason)
glog.V(1).Infof(CLog(Yellow, "Peer.Disconnect: Starting for Peer %v with reason: %v"), pp, reason)
if atomic.LoadInt32(&pp.disconnected) != 0 {
glog.V(1).Infof("Peer.Disconnect: Disconnect call ignored since it was already called before for Peer %v", pp)
return
Expand Down
4 changes: 2 additions & 2 deletions lib/pos_consensus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func (fc *FastHotStuffConsensus) handleBlockProposalEvent(
// 3. Process the vote in the consensus module
// 4. Broadcast the vote msg to the network
func (fc *FastHotStuffConsensus) HandleLocalVoteEvent(event *consensus.FastHotStuffEvent) error {
glog.V(2).Infof("FastHotStuffConsensus.HandleLocalVoteEvent: %s", event.ToString())
glog.V(1).Infof("FastHotStuffConsensus.HandleLocalVoteEvent: %s", event.ToString())
glog.V(2).Infof("FastHotStuffConsensus.HandleLocalVoteEvent: %s", fc.fastHotStuffEventLoop.ToString())

// Hold a read lock on the consensus. This is because we need to check the
Expand Down Expand Up @@ -444,7 +444,7 @@ func (fc *FastHotStuffConsensus) HandleValidatorVote(pp *Peer, msg *MsgDeSoValid
// 3. Process the timeout in the consensus module
// 4. Broadcast the timeout msg to the network
func (fc *FastHotStuffConsensus) HandleLocalTimeoutEvent(event *consensus.FastHotStuffEvent) error {
glog.V(2).Infof("FastHotStuffConsensus.HandleLocalTimeoutEvent: %s", event.ToString())
glog.V(1).Infof("FastHotStuffConsensus.HandleLocalTimeoutEvent: %s", event.ToString())
glog.V(2).Infof("FastHotStuffConsensus.HandleLocalTimeoutEvent: %s", fc.fastHotStuffEventLoop.ToString())

// Hold a read lock on the consensus. This is because we need to check the
Expand Down