Skip to content

Some cleanup#26

Open
atchisson wants to merge 2 commits intodesirepath41:masterfrom
atchisson:master
Open

Some cleanup#26
atchisson wants to merge 2 commits intodesirepath41:masterfrom
atchisson:master

Conversation

@atchisson
Copy link

Hello there,
Thanks for that demo, i will try to integrate it to Symfony 4 latter.
For now, here is some cleanup :

  • old github.io links for .css and .js files was broken, I added the files locally.
  • Unminified demo.css
  • Removed the Google Font link in the CSS, since it's not GDPR compliant anymore. The demo doesn't need external resources anymore.
  • composer.json file doesn't work with Composer v2, display that error :
  [Composer\Json\JsonValidationException]                                                                     
  "./composer.json" does not match the expected JSON schema:                                                  
   - name : Does not match the regex pattern ^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$

I reverted the edit i made to force the install, I'll let you decide actions you want to do with it.

There is a link to emotionloop.com, which is for sales at the moment. I'm not sure if you want to keep it either.

Have a great day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant